Add analysis metrics menu to chart #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
faustoperez
requested changes
Feb 28, 2024
|
As a side note related to this PR @j08lue @sandrahoang686 we need to review the behavior of the interface after triggering an analysis. I suggest:
I suggest we tackle that on #857 |
10 tasks
sandrahoang686
changed the title
j08lue
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Metrics selection works well with the new menu. I am not sure how well it can be found or we should use an icon that hints more at that these are chart-related options, now that the icon is not floating above the lines it is related to, but we can see in user testing, whether that is an issue and address it together with other planned design changes, if need be.
faustoperez
approved these changes
Feb 29, 2024
Merged
hanbyul-here
added a commit
that referenced
this pull request
Mar 25, 2024
## 🎉 Features - Optional media attributes for layers: #843 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 ## 🚀 Improvements - E&A imporvement. Related tickets - Layer select modal: #845 - Connect dataset information on layer: #821 - Layer info modal: #849 - Update data layer card: #851 - Hidden layers: #867 - Fast follow-ups: #851 , #862, #863, #860 - PR template: #880 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826 - Wording, typo: #869 #854, #874, - Fix yaxis labeling: #883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the analysis metrics menu back to each layer list item in the explorations page.
Ticket here
Design here
Question for @faustoperez related to icon button location. I moved the button closer to the right-aligned because of the overlapping arrows. Please let me know what you think. I discuss this more in the demo video if you can take a look. Thanks!
Demo vid:
https://www.loom.com/share/56d013aade7945fdb40bff8cd2f3dc56